Lazy loaded Twig Extension #123
Conversation
qdequippe
force-pushed
the
mercure-twig-runtime
branch
from
d53af01 to
43f8bd4
Compare
There was a problem hiding this comment.
Removing a public method from a class is a breaking change, but I think we can make it of the next 0.minor version.
The extension attributes added in Twig 3.21.0 allows to create lazy extension with a single class. I recommend this approach.
The MercureBundle must also be updated to enable autoconfiguration (or add both twig.attribute_extension and twig.runtime tags): https://github.com/symfony/mercure-bundle/blob/main/src/DependencyInjection/MercureExtension.php#L270-L274
| * | ||
| * @return string The URL of the hub with the appropriate "topic" query parameters (if any) | ||
| */ | ||
| public function mercure($topics = null, array $options = []): string |
There was a problem hiding this comment.
You could keep this function in this class and use the #[TwigFunction] attribute to make this extension lazy.
There was a problem hiding this comment.
Do I need also to remove this config from the bundle? https://github.com/symfony/mercure-bundle/blob/main/src/DependencyInjection/MercureExtension.php#L270-L274
qdequippe
force-pushed
the
mercure-twig-runtime
branch
from
8b3606b to
6cdd947
Compare
qdequippe
force-pushed
the
mercure-twig-runtime
branch
from
6cdd947 to
3000654
Compare
https://symfony.com/doc/8.0/templates.html#templates-twig-extension